ARROW-2316: [C++] Revert Buffer::mutable_data to inline so that linkers do not have to remember to define NDEBUG for release builds #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remember to build with -DNDEBUG Change-Id: I74d930ad213bd60e4c39c37ad11159eae9276fac
Change-Id: I20718bb7e09ec8491ae5ddc1db95d513a065dfe5
Change-Id: I979f5c7f91a555a58dade14a3e0acb8d22c56978
Member
Author
|
+1. Appveyor build looking good: https://ci.appveyor.com/project/wesm/arrow/build/1.0.1778 |
Member
Author
|
Ah, I'm going to wait a while longer for the last commit to build in Appveyor |
Member
Author
|
Appveyor build looking good: https://ci.appveyor.com/project/wesm/arrow/build/1.0.1779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.