Skip to content

[BEAM-8575] Fix window assignment idempotency tests non-deterministic… #10111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanmyrvold merged 1 commit into from
Nov 14, 2019
Merged

[BEAM-8575] Fix window assignment idempotency tests non-deterministic… #10111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdks/python/apache_beam/transforms/window_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,21 +286,21 @@ def test_timestamped_with_combiners(self):
@attr('ValidatesRunner')
def test_window_assignment_idempotency(self):
with TestPipeline() as p:
pcoll = self.timestamped_key_values(p, 'key', 0, 1, 2, 3, 4)
pcoll = self.timestamped_key_values(p, 'key', 0, 2, 4)
result = (pcoll
| 'window' >> WindowInto(FixedWindows(2))
| 'same window' >> WindowInto(FixedWindows(2))
| 'same window again' >> WindowInto(FixedWindows(2))
| GroupByKey())

assert_that(result, equal_to([('key', [0, 1]),
('key', [2, 3]),
assert_that(result, equal_to([('key', [0]),
('key', [2]),
('key', [4])]))

@attr('ValidatesRunner')
def test_window_assignment_through_multiple_gbk_idempotency(self):
with TestPipeline() as p:
pcoll = self.timestamped_key_values(p, 'key', 0, 1, 2, 3, 4)
pcoll = self.timestamped_key_values(p, 'key', 0, 2, 4)
result = (pcoll
| 'window' >> WindowInto(FixedWindows(2))
| 'gbk' >> GroupByKey()
Expand All @@ -309,8 +309,8 @@ def test_window_assignment_through_multiple_gbk_idempotency(self):
| 'same window again' >> WindowInto(FixedWindows(2))
| 'gbk again' >> GroupByKey())

assert_that(result, equal_to([('key', [[[0, 1]]]),
('key', [[[2, 3]]]),
assert_that(result, equal_to([('key', [[[0]]]),
('key', [[[2]]]),
('key', [[[4]]])]))

class RunnerApiTest(unittest.TestCase):
Expand Down