Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to create an Integration Context from an existing image #317

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Option to create an Integration Context from an existing image #317

merged 1 commit into from
Jan 9, 2019

Conversation

lburgazzoli
Copy link
Contributor

Fixes #316

@nicolaferraro
Copy link
Member

Do you mind rebasing it on #315 (I think now it's ready to be merged)? It adds too many breaking changes.

@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Jan 7, 2019 via email

@lburgazzoli
Copy link
Contributor Author

@nicolaferraro rebased

nicolaferraro
nicolaferraro requested changes Jan 7, 2019
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, just one comment about spec vs status

pkg/cmd/context_create.go Outdated Show resolved Hide resolved
@nicolaferraro
Copy link
Member

Looks good, thanks. There's a conflict with the other PR..

@lburgazzoli
Copy link
Contributor Author

@nicolaferraro done

@nicolaferraro nicolaferraro merged commit e5384b6 into apache:master Jan 9, 2019
@lburgazzoli lburgazzoli deleted the ctx-image branch January 9, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lburgazzoli @nicolaferraro @oscerd