CAMEL-11682: Add sasl.jaas.config setting#1897
Closed
snowch wants to merge 1 commit intoapache:masterfrom
snowch:CAMEL-11682
Closed
CAMEL-11682: Add sasl.jaas.config setting#1897snowch wants to merge 1 commit intoapache:masterfrom snowch:CAMEL-11682
snowch wants to merge 1 commit intoapache:masterfrom
snowch:CAMEL-11682
Conversation
oscerd
approved these changes
Aug 22, 2017
Contributor
|
LGTM. Will merge soon. |
Contributor
|
@davsclaus @lburgazzoli @zregvart may I have your feedback too? |
Member
|
@oscerd looks good to me, not sure about the failing tests. I think for future proofing we could add a |
Contributor
|
Thanks for the PR. It has been merged. Can you close this? |
Contributor
|
Is there something missing? I see you reopened the PR.. |
Contributor
Author
|
Sorry, for closing and re-opening. I misread the GITHUB BOT feedback on the Jira ticket and thought I needed to do close the ticket another way. Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested the PR against IBM MessageHub and it worked with the following routes:
and KafkaConsumer
The camel-kafka tests were failing on master before I made my changes. The failures were: