Skip to content

fix(components): milvus not using lombok NotNull any longer #19802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squakez merged 1 commit into from
Nov 4, 2025
Merged

fix(components): milvus not using lombok NotNull any longer #19802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../camel/component/langchain4j/embeddings/LangChain4jEmbeddingsComponentMilvusTargetIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ public void search() {
assertThat(result.getException()).isNull();

assertThat(result.getIn().getBody()).isInstanceOfSatisfying(SearchResponse.class,
c -> assertThat(c.rowRecords.size() == 1));
c -> assertThat(c.getRowRecords().size() == 1));
}

@Test
Expand Down
9 changes: 0 additions & 9 deletions components/camel-ai/camel-milvus/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,6 @@
</exclusions>
</dependency>

<!-- Required as the Milvus API is leaking a @NonNull annotation -->
<!-- TODO: remove when this issue is solved https://github.com/milvus-io/milvus-sdk-java/issues/1651-->
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>${lombok-version}</version>
<scope>provided</scope>
</dependency>

<!-- test dependencies -->
<dependency>
<groupId>org.apache.camel</groupId>
Expand Down
4 changes: 2 additions & 2 deletions ...ai/camel-milvus/src/test/java/org/apache/camel/component/milvus/it/MilvusComponentIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public void search() {

assertThat(result).isNotNull();
assertThat(result.getException()).isNull();
assertThat(result.getMessage().getBody(SearchResponse.class).rowRecords.size() == 2);
assertThat(result.getMessage().getBody(SearchResponse.class).getRowRecords().size() == 2);
}

@Test
Expand Down Expand Up @@ -263,7 +263,7 @@ public void delete() {

assertThat(result).isNotNull();
assertThat(result.getException()).isNull();
assertThat(result.getMessage().getBody(SearchResponse.class).rowRecords.size() == 0);
assertThat(result.getMessage().getBody(SearchResponse.class).getRowRecords().size() == 0);
}

private List<List<Float>> generateFloatVectors(int count) {
Expand Down
6 changes: 1 addition & 5 deletions parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,6 @@
<lifecycle-mapping-version>1.0.0</lifecycle-mapping-version>
<log4j2-version>2.24.3</log4j2-version>
<logback-version>1.5.20</logback-version>
<!-- This is exclusively required in camel-milvus as the dependency is leaking a build time annotation
TODO: remove when this issue is solved https://github.com/milvus-io/milvus-sdk-java/issues/1651
-->
<lombok-version>1.18.42</lombok-version>
<lucene-version>9.12.0</lucene-version>
<lightcouch-version>0.2.0</lightcouch-version>
<littleproxy-version>2.4.6</littleproxy-version>
Expand Down Expand Up @@ -394,7 +390,7 @@
<micrometer-tracing-version>1.5.5</micrometer-tracing-version>
<microprofile-config-version>3.1</microprofile-config-version>
<milo-version>1.0.8</milo-version>
<milvus-client-version>2.6.6</milvus-client-version>
<milvus-client-version>2.6.7</milvus-client-version>
<mina-version>2.2.4</mina-version>
<minidns-version>0.3.4</minidns-version>
<minimal-json-version>0.9.5</minimal-json-version>
Expand Down