Changing the randomisation generation : #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @devnexen, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. Sincerely, |
|
Thank you @devnexen for signing the Contribution License Agreement. Cheers, |
Contributor
|
@devnexen Thanks for taking the time to do this. I'll review this sometime this week. |
mpenick
reviewed
Aug 24, 2017
src/random.cpp
Outdated
| char* err = STRERROR_R_(errno, buf, sizeof(buf)); | ||
| LOG_CRITICAL("Unable to open random device (%s): %s", device, err); | ||
| return seed; | ||
| LOG_WARN("Unable to read %zu random bytes (%s): %zu read", |
mpenick
reviewed
Aug 24, 2017
src/random.cpp
Outdated
| } else { | ||
| readurandom = false; | ||
| } | ||
| #endif |
Contributor
There was a problem hiding this comment.
It would improve readability if this was #endif // defined(HAVE_GETRANDOM). These nested #ifs are hard to follow.
mpenick
reviewed
Aug 24, 2017
src/random.cpp
Outdated
| } | ||
|
|
||
| close(fd); | ||
| #endif |
Contributor
There was a problem hiding this comment.
#endif defined(HAVE_ARC4RANDOM)
Contributor
|
LGTM. Just a couple comments. |
Contributor
|
Thanks for the quick commit. Can you please rebase on master so we can get CI to pass? |
- using getrandom syscall on linux, trying to read as we can in non blocking mode, falling back to dev urandom eventually. - on *BSD and MacOS, using arc4random_buf which does not fail.
devnexen
force-pushed
the
randomization_changes
branch
from
253d48b to
114e6ab
Compare
mikefero
pushed a commit
that referenced
this pull request
Sep 21, 2017
This reverts commit 1683411.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non blocking mode, falling back to dev urandom eventually.