Skip to content

Conversation

@SeverinLeonhardt
Copy link
Contributor

This fixes the following warnings from MSVC:

warning C4245: 'initializing': conversion from 'int' to 'datastax::StringRef::size_type', signed/unsigned mismatch
warning C4245: '=': conversion from 'int' to 'DWORD', signed/unsigned mismatch

This fixes the following warnings from MSVC:

    warning C4245: 'initializing': conversion from 'int' to 'datastax::StringRef::size_type', signed/unsigned mismatch
    warning C4245: '=': conversion from 'int' to 'DWORD', signed/unsigned mismatch
@absurdfarce absurdfarce self-requested a review October 7, 2022 22:00
@absurdfarce
Copy link
Contributor

Thanks for the PR @SeverinLeonhardt! These seem like pretty nice improvements; I had originally wondered about just casting the npos assignment but after thinking about it a bit I think your solution is the better option.

As discussed on the other PR I'm going to hold on merging this until we can get our build infrastructure issues sorted out.

@absurdfarce
Copy link
Contributor

Per comments on #535 merging this now so that it can be included in upcoming release.

Thanks (again) @SeverinLeonhardt !

@absurdfarce absurdfarce merged commit 4c12333 into apache:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants