Skip to content

Conversation

Claudenw
Copy link

@Claudenw Claudenw commented Nov 2, 2023

added Christian Stein copyright notice

performing grep for [Cc]opyright, (C), and (c) only uncovered the one copyright not listed in the Notice file.

NOTICE.txt Outdated
(C) 2018 Christian Stein
This product includes software developed by Christian Stein
see ci/install-jdk.sh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 25 can be removed

Copy link
Contributor

@hhughes hhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I agree the extra newline could be removed (I think this still leaves a newline at the end of the file)

@Claudenw
Copy link
Author

Claudenw commented Nov 3, 2023

Removed the blank line as requested.

@Claudenw Claudenw changed the title CASSANDRA-18969 - added missing copyrights CASSANDRA-18969 - added missing copyrights [4.x] Nov 3, 2023
Copy link
Contributor

@hhughes hhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhughes
Copy link
Contributor

hhughes commented Nov 15, 2023

Please close in favor of #1835 (which retains original contributor credit)

@absurdfarce
Copy link
Contributor

Closing based on quick conversation with @Claudenw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants