Skip to content

CASSANDRA-18969: 4.x Add LICENSE and NOTICE.txt/NOTICE_binary to published jars #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2023
Merged

CASSANDRA-18969: 4.x Add LICENSE and NOTICE.txt/NOTICE_binary to published jars #1864

merged 1 commit into from
Nov 28, 2023

Conversation

hhughes
Copy link
Contributor

@hhughes hhughes commented Nov 17, 2023

No description provided.

@michaelsembwever
Copy link
Member

michaelsembwever commented Nov 18, 2023 •
edited
Loading

Ok.

So what we need to do is…

  1. Copy NOTICE.txt to NOTICE_binary.txt
  2. Remove the netty stuff from NOTICE.txt
  3. Include NOTICE_binary.txt in the jar's META-INF
  4. Add to NOTICE_binary.txt the following
This compiled product also includes Apache-licensed dependencies that contain the following NOTICE information:

This way we are honouring

It is important to keep NOTICE as brief and simple as possible, as each addition places a burden on downstream consumers.

Do not add anything to NOTICE which is not legally required.
…
…As a result, the LICENSE and NOTICE files for a binary distribution may differ from those in the source distribution it was built from.

In any case, the principle remains the same: LICENSE and NOTICE must exactly represent the contents of the distribution they reside in.

ref: https://infra.apache.org/licensing-howto.html#mod-notice

@hhughes hhughes force-pushed the 4.x_apache_pom branch 2 times, most recently from c7af09d to 707f04d Compare November 20, 2023 22:24
@hhughes hhughes marked this pull request as ready for review November 20, 2023 22:33
@hhughes hhughes force-pushed the 4.x_apache_pom branch 2 times, most recently from cf0721c to 0ef7788 Compare November 20, 2023 22:39
@hhughes
Add LICENSE and NOTICE.txt/NOTICE_binary to published jars
7b71834 
LICENSE + NOTICE.txt is added to source jars, LICENSE + NOTICE_binary.txt
is added to regular jars. Make parent project inherit from apache pom.
Updated NOTICE wording to "developed at ..." per latest instructions.

patch by Henry Hughes; reviewed by Mick Semb Wever for CASSANDRA-18969
@hhughes hhughes changed the title CASSANDRA-18969: Add top-level LICENSE and NOTICE.txt to published jars, inherit apache pom CASSANDRA-18969: 4.x Add LICENSE and NOTICE.txt/NOTICE_binary to published jars Nov 27, 2023
@michaelsembwever michaelsembwever merged commit 12e3e3e into apache:4.x Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsembwever michaelsembwever michaelsembwever approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hhughes @michaelsembwever