Skip to content

PYTHON-1402 Run integration tests with DSE 6.9.0 #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

PYTHON-1402 Run integration tests with DSE 6.9.0 #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integration/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,7 @@ def _id_and_mark(f):
greaterthanorequaldse50 = unittest.skipUnless(DSE_VERSION and DSE_VERSION >= Version('5.0'), "DSE 5.0 or greater required for this test")
lessthandse51 = unittest.skipUnless(DSE_VERSION and DSE_VERSION < Version('5.1'), "DSE version less than 5.1 required")
lessthandse60 = unittest.skipUnless(DSE_VERSION and DSE_VERSION < Version('6.0'), "DSE version less than 6.0 required")
lessthandse69 = unittest.skipUnless(DSE_VERSION and DSE_VERSION < Version('6.9'), "DSE version less than 6.9 required")

pypy = unittest.skipUnless(platform.python_implementation() == "PyPy", "Test is skipped unless it's on PyPy")
requiresmallclockgranularity = unittest.skipIf("Windows" in platform.system() or "asyncore" in EVENT_LOOP_MANAGER,
Expand Down
3 changes: 2 additions & 1 deletion tests/integration/cqlengine/statements/test_base_statement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

from tests.integration.cqlengine.base import BaseCassEngTestCase, TestQueryUpdateModel
from tests.integration.cqlengine import DEFAULT_KEYSPACE
from tests.integration import greaterthanorequalcass3_10, TestCluster
from tests.integration import greaterthanorequalcass3_10, lessthandse69, TestCluster

from cassandra.cqlengine.connection import execute

Expand Down Expand Up @@ -101,6 +101,7 @@ def test_insert_statement_execute(self):
self.assertEqual(TestQueryUpdateModel.objects.count(), 0)

@greaterthanorequalcass3_10
@lessthandse69
Copy link
Contributor

@absurdfarce absurdfarce Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why does this test... fail on DSE 6.9? Did we remove support for LIKE or something?

Copy link
Contributor

@absurdfarce absurdfarce Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's because of the removal of SASI.. I see.

Can we replace this with a new SAI test then?

Copy link
Member Author

@lukasz-antoniak lukasz-antoniak Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not the LIKE operator.

SAI does not supports the following query operators for tables with SAI indexes:

  • Strings or Numerics: LIKE, OR, IN

Documentation link.

Copy link
Contributor

@absurdfarce absurdfarce Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CEP has it as a "Phase 2" thing which puts it in the same category as OR queries which were discussed at some length for the Java driver (see CASSANDRA-19931). Excluding for 6.9.0 and up seems like the right answer until we get a better answer from SAI.

def test_like_operator(self):
"""
Test to verify the like operator works appropriately
Expand Down