-
Notifications
You must be signed in to change notification settings - Fork 569
Remove Python 3.8 which reached EOL on Oct 2024, update cryptography lib to 42 #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: goal is for this PR to pre-empt work done on #1246. @bschoening will update this PR to include Python 3.13.5 as well in order to start working on 3.13 support. |
|
@absurdfarce I've updated the PR with the RUNTIMES from #1246 Should 3.11 be removed from here?
|
|
@bschoening I'll add a comment on CI_SCHEDULE_SERVER_VERSION in my actual review of the PR |
absurdfarce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks really good to me @bschoening. A few nits around making sure 3.13 is referenced uniformly as the max supported release (and a few other incidentals) but this looks largely ready to go to me.
|
@absurdfarce I'm not sure what this check in Jenkinsfile is doing and if it should be bumped to 3.13 or not...
|
|
Hey @bschoening that's a problem with a transitive dep + Python 3.12. gremlinpython leverages Tornado which appears to bail at some of the SSL changes in Python 3.12. PYTHON-1368 has the horrible details if you want them. The hack you see is the fix implemented for that ticket. Ultimately we need to get to a version of gremlinpython which (a) won't require Tornado at all or (b) requires a version which is compatible with 3.12. I don't think (b) is an option (since I don't think Tornado is still under active development... ?) so at some point I need to see what gremlinpython uses Tornado for and whether we can just exclude it. My guess was that it's just a testing dependency but I haven't dug deep enough to confirm that yet. Upshot: keep it at Python 3.12 for now since the version of Tornado that's involved starts to be a problem with that version of Python. |
…ntimes, update cryptography lib to 42 (Q4 2024 release)
|
Looks great after your last round of changes @bschoening! I think we're all set to go here! |
|
@absurdfarce please see the revised PR which I believe has address all of the requested changes. |
…