Skip to content

Conversation

@bschoening
Copy link
Contributor

@absurdfarce
Copy link
Contributor

Note: goal is for this PR to pre-empt work done on #1246. @bschoening will update this PR to include Python 3.13.5 as well in order to start working on 3.13 support.

@bschoening
Copy link
Contributor Author

bschoening commented Jul 2, 2025

@absurdfarce I've updated the PR with the RUNTIMES from #1246

Should 3.11 be removed from here?

CI_SCHEDULE_SERVER_VERSION=3.11 4.0 5.0

@absurdfarce
Copy link
Contributor

@bschoening I'll add a comment on CI_SCHEDULE_SERVER_VERSION in my actual review of the PR

Copy link
Contributor

@absurdfarce absurdfarce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks really good to me @bschoening. A few nits around making sure 3.13 is referenced uniformly as the max supported release (and a few other incidentals) but this looks largely ready to go to me.

@bschoening
Copy link
Contributor Author

bschoening commented Jul 2, 2025

@absurdfarce I'm not sure what this check in Jenkinsfile is doing and if it should be bumped to 3.13 or not...

// Determine if server version is Apache CassandraⓇ or DataStax Enterprise
if (env.CASSANDRA_VERSION.split('-')[0] == 'dse') {
if (env.PYTHON_VERSION =~ /3.12.\d+/) {
echo "Cannot install DSE dependencies for Python 3.12.x; installing Apache CassandraⓇ requirements only. See PYTHON-1368 for more detail."
sh label: 'Install Apache CassandraⓇ requirements', script: '''#!/bin/bash -lex
pip install -r test-requirements.txt
'''
}
else {
sh label: 'Install DataStax Enterprise requirements', script: '''#!/bin/bash -lex
pip install -r test-datastax-requirements.txt
'''
}
}

@absurdfarce
Copy link
Contributor

absurdfarce commented Jul 2, 2025

Hey @bschoening that's a problem with a transitive dep + Python 3.12. gremlinpython leverages Tornado which appears to bail at some of the SSL changes in Python 3.12. PYTHON-1368 has the horrible details if you want them.

The hack you see is the fix implemented for that ticket. Ultimately we need to get to a version of gremlinpython which (a) won't require Tornado at all or (b) requires a version which is compatible with 3.12. I don't think (b) is an option (since I don't think Tornado is still under active development... ?) so at some point I need to see what gremlinpython uses Tornado for and whether we can just exclude it.

My guess was that it's just a testing dependency but I haven't dug deep enough to confirm that yet.

Upshot: keep it at Python 3.12 for now since the version of Tornado that's involved starts to be a problem with that version of Python.

…ntimes, update cryptography lib to 42 (Q4 2024 release)
@bschoening bschoening requested a review from absurdfarce July 3, 2025 16:30
@absurdfarce
Copy link
Contributor

Looks great after your last round of changes @bschoening! I think we're all set to go here!

@bschoening
Copy link
Contributor Author

@absurdfarce please see the revised PR which I believe has address all of the requested changes.

@absurdfarce absurdfarce merged commit b1dc94f into apache:master Jul 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants