Skip to content

Fix generation for UUID type #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohityadavcloud merged 1 commit into from
May 25, 2023
Merged

Fix generation for UUID type #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generate/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1291,7 +1291,7 @@ func (s *service) generateConvertCode(cmd, name, typ string) {
pn := s.pn

switch typ {
case "string":
case "string", "UUID":
Copy link
Member

@rohityadavcloud rohityadavcloud May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be UUID or uuid?

Copy link
Member Author

@vishesh92 vishesh92 May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are explicitly setting it to "UUID" in L2096. As of now the value is UUID only for managementserverid. And uuid is being treated as a string. Changing this to uuid causes a lot of changes at other places and removes some helper functions.
https://github.com/apache/cloudstack-go/pull/60/files#diff-39a24c8d3907e38beb5e39b5f0a40df7aa73c38449615f140ec3fca502900e86L2096

This seems to be there because of this.

Copy link
Member

@rohityadavcloud rohityadavcloud May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks for checking @vishesh92

pn("u.Set(\"%s\", v.(string))", name)
case "int":
pn("vv := strconv.Itoa(v.(int))")
Expand Down