-
Notifications
You must be signed in to change notification settings - Fork 1.2k
In Install.md->CloudStack UI Commands(npm) #10593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Pearl1594
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should we remove this line though https://github.com/apache/cloudstack/pull/10593/files#diff-09b140a43ebfdd8dbec31ce72cafffd15164d2860fd390692a030bcb932b54a0R92?
yes and probably edit the line above as well. should read something like |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10593 +/- ##
=========================================
Coverage 16.29% 16.30%
Complexity 13438 13438
=========================================
Files 5674 5674
Lines 499213 499213
Branches 60367 60367
=========================================
+ Hits 81371 81375 +4
+ Misses 408772 408768 -4
Partials 9070 9070
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Pearl1594 @DaanHoogland |
|
Awesome work, congrats on your first merged pull request! |
Description
This PR updates INSTALL.md to include essential setup commands for first-time contributors, ensuring a smoother installation process and reducing setup errors.
Changes:
These improvements will make onboarding easier and reduce setup issues.
#10590
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Minor
Bug Severity
BLOCKER
Critical
Major
Minor
Screenshots :
How Has This Been Tested?
How did you try to break this feature and the system with this change?