NAS BnR: Fix error in Restore and attach volume

[abh1sar]

Description

This PR fixes #11942

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Verified that Restore and Attach Instance is working with the fix.

How did you try to break this feature and the system with this change?

[harikrishna-patnala]

code LGTM

[weizhouapache]

code lgtm

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (8b9f5fd) to head (e3eb148).
⚠️ Report is 26 commits behind head on main.

Files with missing lines	Patch %	Lines
...apache/cloudstack/backup/RestoreBackupCommand.java	0.00%	1 Missing ⚠️
...rg/apache/cloudstack/backup/NASBackupProvider.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11944   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15533    15544   +11     
=========================================
  Files          5909     5909           
  Lines        528970   529059   +89     
  Branches      64602    64617   +15     
=========================================
+ Hits          92917    92944   +27     
- Misses       425603   425661   +58     
- Partials      10450    10454    +4     

Flag	Coverage Δ
uitests	3.58% <ø> (-0.01%)	⬇️
unittests	18.63% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15591

[DaanHoogland]

clgtm

[prashanthr2]

Tested as below now. LGTM

1. Created Instance Backup using NAS provider
2. Clicked on Restore and attach volume
3. Selected the Volume, Instance to attach the volume and clicked on OK. We now see the backup restored as DATADISK on the instance