ui: fix create account/user with saml

[shwstppr]

Description

Fixes #5477
Fixes #5478

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Before change:

After change:

How Has This Been Tested?

[rohityadavcloud]

@blueorangutan ui

[rohityadavcloud]

@blueorangutan ui

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-673)

[rohityadavcloud]

@shwstppr couple of issues, not sure if they are due to the qa.cloudstack.cloud backend of 4.15.1: (the qa.cloudstack.cloud is SAMl enabled and can be used for testing)

1. Check if the normal user/role type should be shown this form, it fails:
   

2. On creating user as normal user type, that fails too (in its own account):
   

3. As domain admin, the IDP list was somehow not shown in the create user form:
   

4. As root admin, I created a new user 'rick' and while creating the user ticked authorise saml sso and selected the IDP however the newly-created user is not SAML2 type:
   

5. For an already authorised saml user, when clicking edit saml authorisation button the IDP is pre-selected as 0 (something wrong in option/value key?)
   

Note: this form also seems to pass invalid entityid in the API, so the user isn't really SAML enabled.

@shwstppr please also test/fix any issues with the createAccount form (which also has the saml authorisation option).

[shwstppr]

@rhtyd Verified mentioned issues with PR build:

1. Normal User role cannot create new users in their own account. Old UI doesn't provide the option and option wasn't there in this PR build as well.
2. Same as 1
3. Fixed this case
4. Fixed with this PR
5. Didn't see this behaviour with this PR build.

Addressed #5477 and #5478
@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-674)

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-675)

[utchoang]

LGTM!

[rohityadavcloud]

@blueorangutan ui

[rohityadavcloud]

LGTM - I'll test and confirm shortly

[rohityadavcloud]

@blueorangutan ui

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-676)

[rohityadavcloud]

@shwstppr outstanding/new issues:

1. Minor - does not refresh user detail page on edit/saving the authorise saml sso form
2. As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid
3. Minor - Create user form doesn't work for domain user the #/user path (as domainid is not passed)

[rohityadavcloud]

@shwstppr is this ready for final test/merge, or you addressing minor issues too?
@blueorangutan ui

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-678)

[shwstppr]

@rhtyd let's move ahead with one for 2

As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid

I'll fix 1 and 3 in another PR #5487

[rohityadavcloud]

LGTM tested!