Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR provides support to filter role permissions i.e., only list the APIs which haven't already been added to a role

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

Test user with 2 role permissions added - addAccountToProject & activateProject:
image

On listing the APIs to add further permissions - notice that the above added APIs aren't included:
image

Deleted one API - say, addAccountToProject:
image

Observed that this API is now available in the dropdown:
image

@Pearl1594 Pearl1594 changed the title ui: Add support to filter Roles permissions ui: Add support to filter role permissions Sep 21, 2021
@Pearl1594 Pearl1594 added this to the 4.16.0.0 milestone Sep 21, 2021
@shwstppr
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5488 (SL-JID-680)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on QA server. LGTM

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez merged commit 5d63379 into apache:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants