-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: fix guest traffic vlan input #6895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix guest traffic vlan input #6895
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Codecov Report
@@ Coverage Diff @@
## 4.17 #6895 +/- ##
============================================
- Coverage 10.34% 10.34% -0.01%
+ Complexity 6610 6609 -1
============================================
Files 2451 2451
Lines 242340 242340
Branches 37924 37924
============================================
- Hits 25070 25061 -9
- Misses 214182 214192 +10
+ Partials 3088 3087 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@shwstppr is this fixing a github issue? If not, can you add a bit more test info for those not familiar with the issue, please?
|
|
Updated description @DaanHoogland |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
not tested yet
Description
Fixes VLAN input while adding guest traffic type for the physical network in the zone wizard.
When adding a zone physical network is not updated with the guest traffic vlan, resulting in network, vm deployments failures.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Using UI,