Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Nov 13, 2022

Description

Fixes VLAN input while adding guest traffic type for the physical network in the zone wizard.
When adding a zone physical network is not updated with the guest traffic vlan, resulting in network, vm deployments failures.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Using UI,

  • Deploy a new zone with zone deployment wizard
  • Verify VLAN for guest traffic type in the physical network is updated
  • Deploy VM in the zone and it shouldn't show any errors.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6895 (LL-JID-234)

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #6895 (b07c28b) into 4.17 (296035d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.17    #6895      +/-   ##
============================================
- Coverage     10.34%   10.34%   -0.01%     
+ Complexity     6610     6609       -1     
============================================
  Files          2451     2451              
  Lines        242340   242340              
  Branches      37924    37924              
============================================
- Hits          25070    25061       -9     
- Misses       214182   214192      +10     
+ Partials       3088     3087       -1     
Impacted Files Coverage Δ
...rg/apache/cloudstack/quota/QuotaStatementImpl.java 36.28% <0.00%> (-3.99%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland
Copy link
Contributor

@shwstppr is this fixing a github issue? If not, can you add a bit more test info for those not familiar with the issue, please?

S### Description

Fixes VLAN input while adding guest traffic type for the physical network in the zone wizard

@shwstppr
Copy link
Contributor Author

Updated description @DaanHoogland

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm
not tested yet

@rohityadavcloud rohityadavcloud added this to the 4.18.0.0 milestone Nov 23, 2022
@rohityadavcloud rohityadavcloud merged commit fca5715 into apache:4.17 Nov 23, 2022
@rohityadavcloud rohityadavcloud modified the milestones: 4.18.0.0, 4.17.2.0 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants