Fix null host tags while creating a zone

[GaOrtiga]

Description

In the UI, during zone creation, if a new host is created without specifying host tags, ACS adds the null tag to it automatically.

This behaviour has been fixed, making it so that no host tags are added in this situation

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

I created a zone through the UI without specifying host tags and verified that no tags were added.

I also created while specifying host tags and verified that they were added accordingly

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.28%. Comparing base (a5508ac) to head (4f72cb6).
Report is 628 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##               main    #8976       +/-   ##
=============================================
+ Coverage     13.17%   15.28%    +2.11%     
- Complexity     9214    11524     +2310     
=============================================
  Files          2725     5425     +2700     
  Lines        258235   474016   +215781     
  Branches      40249    57669    +17420     
=============================================
+ Hits          34013    72446    +38433     
- Misses       219913   393513   +173600     
- Partials       4309     8057     +3748     

Flag	Coverage Δ
uitests	4.27% <ø> (?)
unittests	16.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8976 (QA-JID-323)

[weizhouapache]

good catch @GaOrtiga

I wonder if it is better to consider all the null params

 
+        Object.keys(args).forEach((key) => (args[key] == null) && delete args[key])
         api('addHost', {}, 'POST', args).then(json => {

[GaOrtiga]

good catch @GaOrtiga

I wonder if it is better to consider all the null params

 
+        Object.keys(args).forEach((key) => (args[key] == null) && delete args[key])
         api('addHost', {}, 'POST', args).then(json => {

I do not think this would be necessary, host tags is the only argument on the addhost section of this form that is not required, therefore it is the only one that can be null.

[weizhouapache]

good catch @GaOrtiga
I wonder if it is better to consider all the null params

 
+        Object.keys(args).forEach((key) => (args[key] == null) && delete args[key])
         api('addHost', {}, 'POST', args).then(json => {

I do not think this would be necessary, host tags is the only argument on the addhost section of this form that is not required, therefore it is the only one that can be null.

that's ok, thanks @GaOrtiga

[DaanHoogland]

clgtm

[borisstoyanov]

@blueorangutan package

[blueorangutan]

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9838

[borisstoyanov]

LGTM, manually deployed a zone and there was no tag on the host