Skip to content

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Jul 9, 2024

E271 Multiple spaces after keyword.

There should be only one space after a keyword.

https://www.flake8rules.com/rules/E271.html

Description

This PR cleans up and standardizes the Python code.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally:

pre-commit run --all-files

How did you try to break this feature and the system with this change?

E271 Multiple spaces after keyword.

There should be only one space after a keyword.

https://www.flake8rules.com/rules/E271.html
@codecov
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.53%. Comparing base (b69cc02) to head (57417d2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #9358    +/-   ##
==========================================
  Coverage     15.53%   15.53%            
- Complexity    11966    11969     +3     
==========================================
  Files          5492     5492            
  Lines        480917   480917            
  Branches      62187    62339   +152     
==========================================
+ Hits          74711    74732    +21     
+ Misses       397945   397923    -22     
- Partials       8261     8262     +1     
Flag Coverage Δ
uitests 4.17% <ø> (ø)
unittests 16.30% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbampton
Copy link
Member Author

jbampton commented Jul 9, 2024

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10303

@DaanHoogland DaanHoogland merged commit c6d3f6e into apache:main Jul 9, 2024
@jbampton jbampton deleted the enable-flake8-rule-E271 branch July 9, 2024 08:19
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 15, 2024
@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants