Skip to content

Conversation

@erisu
Copy link
Member

@erisu erisu commented Apr 8, 2019

Platforms affected

none (windows docs only)

Motivation and Context

Description

  • Copied the win8 static images dir into windows dir.
  • Removed images from the copy over that are not used.
  • Renamed packaging.png to vs2015_packaging.png
    • This is so we can later update the images for dev and 9.x but leave the images for 8.x which is still needed.

Testing

none

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
    Did it in wrong format, oops.
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from dblotsky April 8, 2019 00:49
@erisu erisu merged commit f85e7d8 into apache:master Apr 11, 2019
@erisu erisu deleted the windows-img-fix branch April 11, 2019 14:33
@dblotsky
Copy link
Contributor

Thanks for fixing this @erisu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows docs missing images

2 participants