Fix plugman install failure on iOS containing & #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have an iOS project named `Foo & Bar`. When trying to run `cordova plugin add <anything>` an error is thrown:
```
Failed to install 'org.apache.cordova.splashscreen':CordovaError: could not find -Info.plist file, or config.xml file.
at Object.module.exports.parseProjectFile (/Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/platforms/ios.js:193:19)
at Object.ActionStack.process (/Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/util/action-stack.js:55:49)
at handleInstall (/Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:575:20)
at /Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:335:28
at _fulfilled (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:787:54)
at self.promiseDispatch.done (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:816:30)
at Promise.promise.promiseDispatch (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:749:13)
at /Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:509:49
at flush (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:108:17)
at process._tickCallback (node.js:355:11)
could not find -Info.plist file, or config.xml file.
```
The problem is that the xcode parser is saying that the plist path is `Foo \& Bar-Info.plist`, which is obviously wrong as there is no actual backslash. The ampersand seems to be escaped in the `project.pbxproj` file, so I'm not sure this is the best place for the fix, or if this might even be a bug in https://github.com/alunny/node-xcode
Member
|
Patch verified to work. |
Contributor
|
Thanks Casey! btw, Best github picture evar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an iOS project named
Foo & Bar. When trying to runcordova plugin add <anything>an error is thrown:The problem is that the xcode parser is saying that the plist path is
Foo \& Bar-Info.plist, which is obviously wrong as there is no actual backslash. The ampersand seems to be escaped in theproject.pbxprojfile, so I'm not sure this is the best place for the fix, or if this might even be a bug in https://github.com/alunny/node-xcode