Cannot read files under cordova.file.externalRootDirectory for Android 11

[janetcasarez]

Bug Report

Cannot read files under cordova.file.externalRootDirectory for Android 11

Problem

Getting ready for move to Android 11 and new folder locations. I need to move my app user files from old location into new location.
My old location for user files is cordova.file.externalRootDirectory/crossstitch.
New location will be cordova.file.externalRootDirectory/Android/data/com.crochetdesigns.crossstitch/.
However, when I set and in config.xml, I can not read the files under old folder to move them. I assume the change deadline is still Nov 1 2021. Then all apps need to target 30.

If I do an update now and leave it targeted to 29 all is good. But that does not leave users enough time to update the app, use the app to get files moved before Nov 1 deadline. I have been trying to solve this problem for over a month now. I have 11 apps in the playstore that I will need to do this for.

What is expected to happen?

Allow apps targeted for 30 to read all files under cordova.file.externalRootDirectory.

What does actually happen?

can only read my .png files under cordova.file.externalRootDirectory/crosssstitch folder

Information

Command or Code

Test code below:

var movePatFiles = {

movePatFiles: function () {
// old location of files
try {
window.resolveLocalFileSystemURL(cordova.file.externalRootDirectory, movePatFiles.feMovePattFiles, movePatFiles.moveFail);

    }
    catch (error) {
        alert(error);
    }
},

feMovePattFiles: function (fileSystem) {
// folder already exists
try {
fileSystem.root.getDirectory("crossstitch", { create: true, exclusive: false }, movePatFiles.feMovePatternFiles, movePatFiles.moveFail);
}
catch (error) {
alert(error);
}
},
feMovePatternFiles: function (directoryEntry) {

    // read from cordova.file.externalRootDirectory + "crossstitch" + "/"
    // read all the files in the folder
    var reader = directoryEntry.createReader();
    reader.readEntries(movePatFiles.getPatFileList, movePatFiles.moveFail);
},

getPatFileList: function (entries) {
var patFiles = [];
for (var i = 0; i < entries.length; i++) {

        // only finds my .png files
         alert (entries[i].name);
        
    }
    return patFiles;
},

moveFail: function (error) {
alert("fail");

}

}

Environment, Platform, Device

Android 11 only.

Version information

cordova version 10.0.0
cordova-plugin-file 6.0.2 "File"

Checklist

• [ x] I searched for existing GitHub issues
• [x ] I updated all Cordova tooling to most recent version
• [ x] I included all the necessary information above

[breautek]

If you're app has the READ_EXTERNAL_STORAGE permission granted, in my testing reading from external storage works, however some APIs did not attempt to request permission. Reading directories was one of those methods. I have an open PR that corrects this specific issue, but not sure if that covers all cases for external storage. You can try applying that PR to see if it addresses your issue. Note that any app that has been prompted for external storage permissions but been previously denied may result in an automatic denial of the permission, in which case the user must navigate to the permission settings themselves to enable the permission.

READ_EXTERNAL_STORAGE permission isn't always necessary for reading files in external storage, but it is necessary when reading files that doesn't belong to your app. I believe anything outside of your application's external data directory is considered not own by your app (with the exception of the predefined MediaStore containers, which has some special rules).

[janetcasarez]

Norman, Thanks for your quick reply. Sorry, I should have mentioned it before. I already check permission for READ_EXTERNAL_STORAGE. cordova-plugin-android-permissions 1.1.2 Below is sample code: I get the alert "has permission". From what I understand READ_EXTERNAL_STORAGE is granted by default. You don't need to request it. I still can only read the .png files and not my pattern files. testPermissions: function () { var permissions = cordova.plugins.permissions; permissions.hasPermission(permissions.READ_EXTERNAL_STORAGE, function (status) { if (status.hasPermission) { // Permission has been granted previously, no need to request it again. alert("has permission"); // I get this alert //movePatFiles.testfile1(); } else { var error = function () { // Permission has been denied. This example just logs warning, // make sure to handle this state in your application UI - e.g. // inform your user that you can't open the PDF without their permissions or similar. console.warn('External storage permission has been denied'); }; var success = function (status) { if (!status.hasPermission) { // Permission has been denied. error(); } else { // Permission has been granted, present the document. //presentDocument(); alert("got permission 2"); //movePatFiles.testfile1(); } }; // Request the permission to read files from external storage. permissions.requestPermission(permissions.READ_EXTERNAL_STORAGE, movePatFiles.moveSuccess, movePatFiles.moveFail); } }) },

…

---------------------------------------- From: "Norman Breau" ***@***.***> Sent: Thursday, September 16, 2021 6:10 PM To: "apache/cordova-plugin-file" ***@***.***> Cc: "janetcasarez" ***@***.***>, "Author" ***@***.***> Subject: Re: [apache/cordova-plugin-file] Cannot read files undercordova.file.externalRootDirectory for Android 11 (#494) If you're app has the READ_EXTERNAL_STORAGE permission granted, in my testing reading from external storage works, however some APIs did not attempt to request permission. Reading directories was one of those methods. I have an open PR that corrects this specific issue, but not sure if that covers all cases for external storage. You can try applying that PR to see if it addresses your issue. Note that any app that has been prompted for external storage permissions but been previously denied may result in an automatic denial of the permission, in which case the user must navigate to the permission settings themselves to enable the permission. READ_EXTERNAL_STORAGE permission isn't always necessary for reading files in external storage, but it is necessary when reading files that doesn't belong to your app. I believe anything outside of your application's external data directory is considered not own by your app (with the exception of the predefined MediaStore containers, which has some special rules). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[janetcasarez]

I guess I should also mention. using preference name="android-targetSdkVersion" value="29"
works fine. The problem shows up when set to 30.

[breautek]

I guess I should also mention. using preference name="android-targetSdkVersion" value="29"
works fine. The problem shows up when set to 30.

I'll retry my test app against API 30, it's possible that I'm recalling memory while testing API 29 to see if I reproduce the same issue.

In my test app I can read the directory to list them, while having the READ_EXTERNAL_STORAGE permission granted. I also adb push files into /storage/emulated/0/ and appeared to be able to resolve the root external directory, directoryEntry.getFile to obtain the FileEntry and was able to read files fine.

Can you maybe try my PR via cordova plugin add https://github.com/breautek/cordova-plugin-file.git#feat/api30 ?

Ref: #487

[janetcasarez]

Thanks I appreciate that. Janet

…

---------------------------------------- From: "Norman Breau" ***@***.***> Sent: Monday, September 20, 2021 7:31 PM To: "apache/cordova-plugin-file" ***@***.***> Cc: "janetcasarez" ***@***.***>, "Author" ***@***.***> Subject: Re: [apache/cordova-plugin-file] Cannot read files undercordova.file.externalRootDirectory for Android 11 (#494) I guess I should also mention. using preference name="android-targetSdkVersion" value="29" works fine. The problem shows up when set to 30. I'll retry my test app against API 30, it's possible that I'm recalling memory while testing API 29 to see if I reproduce the same issue. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[breautek]

FYI, noticed you're replying via email. I've edited my commented above which you probably didn't see unless if you actually clicked the link and viewed the comment on GitHub.

[janetcasarez]

Thanks. Didn't see it. Will get that a try. Janet

…

---------------------------------------- From: "Norman Breau" ***@***.***> Sent: Thursday, September 23, 2021 1:50 PM To: "apache/cordova-plugin-file" ***@***.***> Cc: "janetcasarez" ***@***.***>, "Author" ***@***.***> Subject: Re: [apache/cordova-plugin-file] Cannot read files undercordova.file.externalRootDirectory for Android 11 (#494) FYI, noticed you're replying via email. I've edited my commented above which you probably didn't see unless if you actually clicked the link and viewed the comment on GitHub. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[janetcasarez]

cordova plugin add https://github.com/breautek/cordova-plugin-file.git#feat/api30

Failed to fetch plugin https://github.com/breautek/cordova-plugin-file.git#feat/api30 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
CordovaError: Error: npm: Command failed with exit code 1 Error output:
npm ERR! code ENOENT
npm ERR! syscall spawn git
npm ERR! path git
npm ERR! errno ENOENT
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t https://github.com/breautek/cordova-plugin-file.git
npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

log file below
0 info it worked if it ends with ok
1 verbose cli [ 'C:\Program Files\nodejs\node.exe',
1 verbose cli 'C:\Users\Janet\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js',
1 verbose cli 'install',
1 verbose cli 'https://github.com/breautek/cordova-plugin-file.git#feat/api30',
1 verbose cli '--save-dev' ]
2 info using npm@6.14.11
3 info using node@v10.18.0
4 verbose npm-session 0c4216be30d3a5ca
5 silly install loadCurrentTree
6 silly install readLocalPackageData
7 silly fetchPackageMetaData error for git+https://github.com/breautek/cordova-plugin-file.git#feat/api30 Error while executing:
7 silly fetchPackageMetaData undefined ls-remote -h -t https://github.com/breautek/cordova-plugin-file.git
7 silly fetchPackageMetaData
7 silly fetchPackageMetaData
7 silly fetchPackageMetaData spawn git ENOENT
8 timing stage:rollbackFailedOptional Completed in 0ms
9 timing stage:runTopLevelLifecycles Completed in 577ms
10 verbose stack Error: spawn git ENOENT
10 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:240:19)
10 verbose stack at onErrorNT (internal/child_process.js:415:16)
10 verbose stack at process._tickCallback (internal/process/next_tick.js:63:19)
11 verbose cwd D:\AAmyStuff\ABlackStitchCreator\BlackStitchCreator
12 verbose Windows_NT 10.0.19042
13 verbose argv "C:\Program Files\nodejs\node.exe" "C:\Users\Janet\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js" "install" "https://github.com/breautek/cordova-plugin-file.git#feat/api30" "--save-dev"
14 verbose node v10.18.0
15 verbose npm v6.14.11
16 error code ENOENT
17 error syscall spawn git
18 error path git
19 error errno ENOENT
20 error enoent Error while executing:
20 error enoent undefined ls-remote -h -t https://github.com/breautek/cordova-plugin-file.git
20 error enoent
20 error enoent
20 error enoent spawn git ENOENT
21 error enoent This is related to npm not being able to find a file.
22 verbose exit [ 1, true ]

[breautek]

You don't have git installed, or you don't have git in your system PATH variable.

[janetcasarez]

Installed git. Installed plugin. cordova-plugin-file 7.0.0-dev "File"
Will test soon.

[janetcasarez]

No change. I still can only read png files.

It does not see the c2021827103827.cht file in image above.

---

alert(entries.legth) below is "1". alert("entries[i].name:" + entries[i].name); is "entries[i].name: c2021827103827pattern.png"

getPatternList30: function (entries) {
// for each file
// get a file entry for the file
alert(entries.length);
for (var i = 0; i < entries.length; i++) {
alert("entries[i].name:" + entries[i].name);
try {
if (entries[i].name.indexOf(buy.enableCreateFilename) >= 0) {
entries[i].copyTo(movePatFiles.newFolderEntry, entries[i].name, movePatFiles.moveSuccess, movePatFiles.moveFail);
}
else {
entries[i].moveTo(movePatFiles.newFolderEntry, entries[i].name, movePatFiles.moveSuccess, movePatFiles.moveFail);
}
}
catch (error) {
}
}
app.createFreePatFilesList(myPat.freePatList);
},

[breautek]

Thanks.. I have two questions

1. May I ask what creates/writes the c2021827103827.cht file? Is it your app? Is it an third-party app?
2. What API are you using to get the entries list? Is it var reader = directoryEntry.createReader(); reader.readEntries(movePatFiles.getPatFileList, movePatFiles.moveFail);?

[janetcasarez]

1. My app creates the pattern file c2021827103827.cht 2. Yes. var reader = directoryEntry.createReader(); reader.readEntries(movePatFiles.getPatFileList30, movePatFiles.moveFail); Janet

…

---------------------------------------- From: "Norman Breau" ***@***.***> Sent: Monday, September 27, 2021 12:08 PM To: "apache/cordova-plugin-file" ***@***.***> Cc: "janetcasarez" ***@***.***>, "Author" ***@***.***> Subject: Re: [apache/cordova-plugin-file] Cannot read files undercordova.file.externalRootDirectory for Android 11 (#494) Thanks.. I have two questions May I ask what creates/writes the c2021827103827.cht file? Is it your app? Is it an third-party app? What API are you using to get the entries list? Is it var reader = directoryEntry.createReader(); reader.readEntries(movePatFiles.getPatFileList, movePatFiles.moveFail);? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.