Skip to content

[iOS] Simplify the code in resolveLocalFileSystemURI #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[iOS] Simplify the code in resolveLocalFileSystemURI #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/ios/CDVFile.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,19 +233,14 @@ - (void)resolveLocalFileSystemURI:(CDVInvokedUrlCommand*)command
// see if exists and is file or dir
BOOL bExists = [fileMgr fileExistsAtPath:path isDirectory:&isDir];
if (bExists) {
// see if it contains docs path
NSRange range = [path rangeOfString:self.appDocsPath];
// see if it contains docs path or temp path
NSString* foundFullPath = nil;
// there's probably an api or easier way to figure out the path type but I can't find it!
if ((range.location != NSNotFound) && (range.length == [self.appDocsPath length])) {
if ([path hasPrefix:self.appDocsPath]) {
foundFullPath = self.appDocsPath;
} else {
// see if it contains the temp path
range = [path rangeOfString:self.appTempPath];
if ((range.location != NSNotFound) && (range.length == [self.appTempPath length])) {
foundFullPath = self.appTempPath;
}
} else if ([path hasPrefix:self.appTempPath]) {
foundFullPath = self.appTempPath;
}

if (foundFullPath == nil) {
// error SECURITY_ERR - not one of the two paths types supported
result = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsInt:SECURITY_ERR];
Expand Down