Skip to content

Conversation

@beckyconning
Copy link

Resolves this issue https://issues.apache.org/jira/browse/CB-5717

Needs testing for other situations.
Doesn't resolve this issue where screen the KeyboardShrinksView preference is true.

I'm sure this breaks something but it fixes my issue. Perhaps someone more experienced could test the keyboard toggle behaviour where the HideKeyboardFormAccessoryBar preference is true.

Resolves this issue https://issues.apache.org/jira/browse/CB-5717

Needs testing for other situations. Doesn't resolve this issue where screen the KeyboardShrinksView preference is true.
@beckyconning
Copy link
Author

Hi could someone please explain why this was closed? Especially from that commit. It seems unrelated. Has the issue been resolved?

@purplecabbage
Copy link
Contributor

This was not intended to be closed. This is because @shazron used the term 'Fixes #1' in his commit ( refering to 1. Any backgrounded app can potentially access this local web server when your app is running. )
Github auto closed pull request #1 as a result

@shazron
Copy link
Member

shazron commented Nov 8, 2014

Sorry about that. I was merging something from another repo and wanted to keep the history, and github was being clever. Re-open please (we don't have the karma - only issue creators do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants