Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Aug 28, 2024

Which issue does this PR close?

Closes #879.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya
Copy link
Member Author

viirya commented Aug 28, 2024

cc @huaxingao

@viirya viirya force-pushed the add_broadcast_child_node branch from 052f9ad to 95cd31f Compare August 28, 2024 20:01
Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @viirya

@huaxingao huaxingao merged commit af72fd1 into apache:main Aug 29, 2024
@huaxingao
Copy link
Contributor

Merged. Thanks @viirya

@viirya
Copy link
Member Author

viirya commented Aug 29, 2024

Thank you @huaxingao

@viirya viirya deleted the add_broadcast_child_node branch August 29, 2024 05:05
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShuffleQueryStageExec could be direct child node of CometBroadcastExchangeExec

2 participants