chore: remove redundant error transformation #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesejo
force-pushed
the
chore/remove-exception-transformation
branch
from
651b3e5 to
14697ad
Compare
mesejo
force-pushed
the
chore/remove-exception-transformation
branch
from
14697ad to
6fa8ea8
Compare
timsaucer
approved these changes
Sep 14, 2025
Member
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
Very nice cleanup. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The transformation from DataFusionError to PyErr is redundant, and additionally, the type (NotImplementedError) information is lost. This also works towards the goal of providing better error (types, messages, and stack traces) as requested in #1226
What changes are included in this PR?
Remove redundant error transformations
Are there any user-facing changes?
No