Skip to content

Fix panic when parsing REPLACE #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix panic when parsing REPLACE #1140

merged 1 commit into from
Feb 28, 2024
+39 −1

Conversation

@jjbayer
Copy link
Contributor

@jjbayer jjbayer commented Feb 18, 2024

Bubble up an error when parse_insert fails in parse_replace.

@jjbayer jjbayer marked this pull request as ready for review February 18, 2024 16:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7950358329

Details

  • 0 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 87.695%
Totals Coverage Status
Change from base Build 7915258585: 0.008%
Covered Lines: 19670
Relevant Lines: 22430
💛 - Coveralls

This was referenced Feb 19, 2024
Closed
Merged
jjbayer added a commit to getsentry/relay that referenced this pull request Feb 19, 2024
@jjbayer
fix(spans): Don't panic (#3134)
9b127ed 
Switch to `sqlparser` fork until
apache/datafusion-sqlparser-rs#1140 is merged.
@alamb alamb mentioned this pull request Feb 26, 2024
Closed
9 tasks
alamb
alamb approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix and the well commented tests and code @jjbayer

@alamb alamb merged commit b284fdf into apache:main Feb 28, 2024
@alamb alamb changed the title Fix panic for REPLACE Fix panic when parsing REPLACE Feb 28, 2024
@jjbayer jjbayer deleted the replace-into branch March 22, 2024 07:56
@jjbayer jjbayer mentioned this pull request Mar 22, 2024
Merged
jjbayer added a commit to getsentry/relay that referenced this pull request Mar 25, 2024
@jjbayer @olksdr
chore(spans): Upgrade SQL parser (#3311)
2863f6d 
We can move off our own fork now that
apache/datafusion-sqlparser-rs#1140 has been merged &
released.

---------

Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjbayer @coveralls @alamb