Skip to content

Conversation

lewiszlw
Copy link
Member

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

@coveralls
Copy link

coveralls commented Sep 1, 2024

Pull Request Test Coverage Report for Build 10653659255

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 62 of 68 (91.18%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 89.251%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/generic.rs 1 2 50.0%
src/dialect/mod.rs 1 2 50.0%
src/dialect/postgresql.rs 1 2 50.0%
src/parser/mod.rs 8 9 88.89%
tests/sqlparser_common.rs 35 37 94.59%
Totals Coverage Status
Change from base Build 10653580269: 0.004%
Covered Lines: 28737
Relevant Lines: 32198

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lewiszlw @iffyio and @git-hulk

I pushed a commit to this PR to fix the CI doc failure too

@alamb alamb merged commit 4d52ee7 into apache:main Sep 1, 2024
@alamb
Copy link
Contributor

alamb commented Sep 1, 2024

Thanks again !

ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants