Skip to content

Conversation

samuelcolvin
Copy link
Contributor

I don't know how you feel about changes like this? Feel free to close.

Personally I find the cleaner syntax easier to understand.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10611360052

Details

  • 50 of 50 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 89.205%

Totals Coverage Status
Change from base Build 10566352051: -0.002%
Covered Lines: 28600
Relevant Lines: 32061

💛 - Coveralls

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, good cleanup.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samuelcolvin and @iffyio

@alamb
Copy link
Contributor

alamb commented Sep 1, 2024

I don't know how you feel about changes like this? Feel free to close.

FWIW I think changes like this to improve the code readability that are clear and broken into small PRs for easy review are great.

THank you @samuelcolvin @git-hulk and @iffyio

@alamb alamb merged commit d64beea into apache:main Sep 1, 2024
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants