Travis CI fixes #159
Merged
Travis CI fixes #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"iter.next() is equivalent to iter.nth(0), as they both consume the next element, but is more readable." https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
nickolay
changed the title
.nth(0)) to unbreak CI
nickolay
added a commit
to nickolay/sqlparser-rs
that referenced
this pull request
May 26, 2020
… workflows This should fix the build failures due to unavailable components, e.g. error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download for channel nightly Sometimes not all components are available in any given nightly.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @eyalleshem for noticing, a clippy update added a new lint, which now fails on Travis:
https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
After fixing that, I took advantage of the fact that
rustupcan now install find the nightly with the necessary components instead of complaining that the most recent one is broken.I also noticed that coverage broke due to a change to the Cargo.lock format and tried to fix that by importing the unreleased version from roblabla/cargo-travis#66 , but that resulted in linking errors, so I dropped it.