-
Notifications
You must be signed in to change notification settings - Fork 666
feat: Parse special keywords as functions (current_user, user, etc) #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 2839618346Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ovr -- looks good to me except for a question about the special field
| pub over: Option<WindowSpec>, | ||
| // aggregate functions may specify eg `COUNT(DISTINCT x)` | ||
| pub distinct: bool, | ||
| pub special: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why a special field is needed ? Wouldn't it be enough to match on the name?
If we do need a special field, can you please add a /// comment explaining what it means and what it is used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Marking this as a draft to show it is waiting some changes so I can easily filter out which PRs need review. Please mark it as "ready for review" when it is next ready. |
8b700ff to
a6a3340
Compare
|
Thanks @ovr |
Can drop this after rebase on commit 54a29e8 " feat: Parse special keywords as functions (current_user, user, etc) (apache#561)", first released in 0.21.0
Can drop this after rebase on commit 54a29e8 " feat: Parse special keywords as functions (current_user, user, etc) (apache#561)", first released in 0.21.0

Hello!
https://www.postgresql.org/docs/9.1/functions-info.html
Thanks