Skip to content

date_bin: incorrect binning at date_bin boundaries before the epoch #13145

@mhilton

Description

@mhilton

Describe the bug

For times before the unix epoch (1970-01-01T00:00:00) times at the boundary are incorrectly put into the previous time bin.

To Reproduce

In datafusion-cli:

> SELECT date_bin(INTERVAL '30 second', '1969-12-31T19:00:00') as t;
+---------------------+
| t                   |
+---------------------+
| 1969-12-31T18:59:30 |
+---------------------+
1 row(s) fetched. 
Elapsed 0.002 seconds.

> SELECT date_bin(INTERVAL '30 second', '1969-12-31T19:00:30') as t;
+---------------------+
| t                   |
+---------------------+
| 1969-12-31T19:00:00 |
+---------------------+
1 row(s) fetched. 
Elapsed 0.001 seconds.

Expected behavior

A time at the date_bin boundary to be in the correct bin:

> SELECT date_bin(INTERVAL '30 second', '1969-12-31T19:00:00') as t;
+---------------------+
| t                   |
+---------------------+
| 1969-12-31T19:00:00 |
+---------------------+
1 row(s) fetched. 
Elapsed 0.002 seconds.

> SELECT date_bin(INTERVAL '30 second', '1969-12-31T19:00:30') as t;
+---------------------+
| t                   |
+---------------------+
| 1969-12-31T19:00:30 |
+---------------------+
1 row(s) fetched. 
Elapsed 0.001 seconds.

Additional context

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions