Skip to content

JoinSetTracerError is not exported from datafusion-common-runtime #17876

@JanKaul

Description

@JanKaul

Describe the bug

The JoinSetTracerError type is used in the public API of datafusion-common-runtime but is not exported, making it impossible for downstream users to properly handle errors from set_join_set_tracer().

To Reproduce

Try to use the crate from downstream code:

use datafusion_common_runtime::{set_join_set_tracer, JoinSetTracerError};
//                                                    ^^^^^^^^^^^^^^^^^^
//                                                    Not exported!

This fails because JoinSetTracerError is not in the public exports.

Expected behavior

Since set_join_set_tracer() returns Result<(), JoinSetTracerError>, users should be able to access JoinSetTracerError to handle errors properly.

Current code

In datafusion/common-runtime/src/lib.rs (line 33):

pub use trace_utils::{set_join_set_tracer, JoinSetTracer};

The function set_join_set_tracer is exported, but its error type JoinSetTracerError is not.

Suggested fix

Add JoinSetTracerError to the re-exports:

pub use trace_utils::{set_join_set_tracer, JoinSetTracer, JoinSetTracerError};

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions