Skip to content

LogicalPlan::replace_params_with_values should not take &Vec<_> #5573

@kawadakk

Description

@kawadakk

Describe the bug
LogicalPlan::replace_params_with_values takes &Vec<ScalarValue>, forcing the caller to collect inputs in Vec<ScalarValue> (instead of an arbitrary continuous container) with no benefits.

https://github.com/apache/arrow-datafusion/blob/aeb593f719508973fa4564a32bc2adc767c3713e/datafusion/expr/src/logical_plan/plan.rs#L630-L636

To Reproduce
N/A

Expected behavior
A common practice, enforced by the ptr_arg Clippy lint, is to pass such parameters by slice references (&[ScalarValue]).

Additional context
N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions