Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions datafusion/core/src/physical_planner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -216,29 +216,27 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) -> Result<String> {
let expr = create_physical_name(expr, false)?;
Ok(format!("{expr} IS NOT UNKNOWN"))
}
Expr::GetIndexedField(GetIndexedField { expr: _, field }) => {
match field {
GetFieldAccess::NamedStructField { name: _ } => {
unreachable!(
"NamedStructField should have been rewritten in OperatorToFunction"
Expr::GetIndexedField(GetIndexedField { expr: _, field }) => match field {
GetFieldAccess::NamedStructField { name: _ } => {
internal_err!(
"NamedStructField is no longer supported. Should use the get_field function instead"
)
}
GetFieldAccess::ListIndex { key: _ } => {
unreachable!(
"ListIndex should have been rewritten in OperatorToFunction"
}
GetFieldAccess::ListIndex { key: _ } => {
internal_err!(
"ListIndex is no longer supported. Should use the get_field function instead"
)
}
GetFieldAccess::ListRange {
start: _,
stop: _,
stride: _,
} => {
unreachable!(
"ListRange should have been rewritten in OperatorToFunction"
}
GetFieldAccess::ListRange {
start: _,
stop: _,
stride: _,
} => {
internal_err!(
"ListRange is no longer supported. Should use the get_field function instead"
)
}
};
}
}
},
Expr::ScalarFunction(fun) => fun.func.display_name(&fun.args),
Expr::WindowFunction(WindowFunction {
fun,
Expand Down
2 changes: 1 addition & 1 deletion datafusion/functions-array/src/rewrite.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pub(crate) struct ArrayFunctionRewriter {}

impl FunctionRewrite for ArrayFunctionRewriter {
fn name(&self) -> &str {
"FunctionRewrite"
"ArrayFunctionRewriter"
}

fn rewrite(
Expand Down