Fix overflow in pow #11124
Merged
Fix overflow in pow #11124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 26, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @LorrensP-2158466
| (Some(base), Some(exp)) => Ok(Some(base.pow_checked( | ||
| exp.try_into().map_err(|_| { | ||
| exec_datafusion_err!( | ||
| "Can't use negative exponents: {exp} in integer computation, please use Float." |
jonahgao
approved these changes
Jun 26, 2024
Member
jonahgao
left a comment
jonahgao
left a comment
There was a problem hiding this comment.
LGTM, thanks @LorrensP-2158466
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* checked overflow on integer parameter * added slt test * fix: forgot to remove failling test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11075.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Added SLT test
Are there any user-facing changes?
no