fix: Ignore nullability in Substrait structs #11130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to https://github.com/apache/datafusion/pull/10874/files Arrow requires schema to match exactly to literals. Substrait contains nullability separate in literals and types, and the nullability of a literal may vary row-by-row. The only reliable way is to either not use nullability at all (this PR), or alternatively pass the expected type into from_substrait_literal so that it can use the expected nullability.
Contributor
|
Thanks again @Blizzara |
Member
|
Don't use the nullability field seems to be a good workaround we can get at present. This (as well as #10874) didn't make things dangerous as we already ignore this field in some places, but they made the logic consistent. So this approach looks good to me, the downside of losing nullability information in substrait seems acceptable. |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Similar to https://github.com/apache/datafusion/pull/10874/files Arrow requires schema to match exactly to literals. Substrait contains nullability separate in literals and types, and the nullability of a literal may vary row-by-row. The only reliable way is to either not use nullability at all (this PR), or alternatively pass the expected type into from_substrait_literal so that it can use the expected nullability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to https://github.com/apache/datafusion/pull/10874/files
Which issue does this PR close?
Closes #.
Rationale for this change
Arrow requires schema to match exactly to literals. Substrait contains nullability separate in literals and types, and the nullability of a literal may vary
row-by-row.
The only reliable way I can think of is to either not use nullability at all (this PR), or alternatively pass the expected type into from_substrait_literal so that it can use the expected nullability.
What changes are included in this PR?
Ignore nullability when consuming Substrait struct type and literal, always erring on the side of
nullable = trueAre these changes tested?
Tested by existing unit tests
Are there any user-facing changes?