fix(typo): unqualifed to unqualified #11159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
github-actions
bot
added
logical-expr
Contributor
|
Thanks @waynexia
I think that would be the most user friendly option if you can do so |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Member
Author
comphead
reviewed
Jun 28, 2024
|
|
||
| /// Create a new `DFSchema` from a list of Arrow [Field]s | ||
| #[deprecated( | ||
| since = "40.0.0", |
comphead
reviewed
Jun 28, 2024
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* fix(typo): unqualifed to unqualified Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * keep the old API Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * Update datafusion/common/src/dfschema.rs Co-authored-by: Oleks V <comphead@users.noreply.github.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I find (actually this is found by my typo ci) this typo "unqualifed" in our public API.
What changes are included in this PR?
Correct the typo
Are these changes tested?
Are there any user-facing changes?
Yes, this is a breaking change.
I'm not sure how we should handle this. Maybe add a new correct spelling method that proxies to the current implementation, and deprecate the typo one?
Further more, is it necessary to setup a typo CI in this repository as well 🤔