minor: consolidate gcd related tests
#11164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
commented
Jun 28, 2024
| ; | ||
|
|
||
| query II | ||
| select gcd(20, 1000), lcm(20, 1000); |
Member
Author
There was a problem hiding this comment.
This test has been split and moved.
alamb
approved these changes
Jun 28, 2024
| query error DataFusion error: Arrow error: Compute error: Signed integer overflow in GCD\(0, \-9223372036854775808\) | ||
| select gcd(0, -9223372036854775808); | ||
|
|
||
| # Test gcd with zero and negative values |
Contributor
There was a problem hiding this comment.
this was combined with other examples I think
Member
Author
There was a problem hiding this comment.
Yes. gcd(0, 0) was duplicated with another test, and negative tests was moved too.
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 2, 2024
* minor: consolidate gcd related tests * fix comment
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* minor: consolidate gcd related tests * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
What changes are included in this PR?
The tests for the
GCDfunction exist in bothscalar.sltandmath.slt; it would be best to combine them.This PR moves them all into
math.slt.Are these changes tested?
Yes
Are there any user-facing changes?
No