Minor: Update exected output due to logical conflict #11824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
alamb
commented
Aug 5, 2024
| 01)Limit: skip=0, fetch=5 | ||
| 02)--Aggregate: groupBy=[[aggregate_test_100.c3, MIN(aggregate_test_100.c1)]], aggr=[[]] | ||
| 03)----Aggregate: groupBy=[[aggregate_test_100.c3]], aggr=[[MIN(aggregate_test_100.c1)]] | ||
| 02)--Aggregate: groupBy=[[aggregate_test_100.c3, min(aggregate_test_100.c1)]], aggr=[[]] |
Contributor
Author
There was a problem hiding this comment.
the case of the aggregate name is different
lewiszlw
approved these changes
Aug 5, 2024
Member
lewiszlw
left a comment
lewiszlw
left a comment
There was a problem hiding this comment.
I noticed this too and planning to fix it.
Contributor
Author
|
Thanks @lewiszlw -- let's merge this once the tests pass green to get CI back success |
Contributor
Author
|
✅ |
Contributor
Author
|
Thanks for the speedy review @lewiszlw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
CI is failing on main, for example https://github.com/apache/datafusion/actions/runs/10251066368/job/28358425606
I think it is a logical conflict between #11795 and #11814
What changes are included in this PR?
Update test output
Are these changes tested?
Are there any user-facing changes?
No, this is just a development process change