Move optimizer integration tests to core_integration
#11830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
force-pushed
the
move-aggregate-statistics-to-datafusion-physical-optimizer
branch
from
3e8d99a to
5b46597
Compare
lewiszlw
approved these changes
Aug 6, 2024
Member
lewiszlw
left a comment
lewiszlw
left a comment
There was a problem hiding this comment.
Make sense. Thanks!
Verified these tests are run as part of CI.
alamb
deleted the
move-aggregate-statistics-to-datafusion-physical-optimizer
branch
Contributor
Author
|
Thank @lewiszlw ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up #11798
Part of #11502
Rationale for this change
@Weijun-H and I are working to prepare to move all the physical optimizer rules
into a new crate, so ensuring the existing code has a good pattern to follow is
important
What changes are included in this PR?
Are these changes tested?
Yes, by CI
The optimizer tests can now be run like
cargo test --test core_integration -- optimizerAre there any user-facing changes?
No