Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 5, 2024

Which issue does this PR close?

N/A

Rationale for this change

Each individual .rs file in the tests directory results in a new test binary which means:

  • 10s of MB of new binary (and thus slower)
  • It can't run in parallel with other tests (only tests within the same binary do)

What changes are included in this PR?

Consolidate the path_partition test into the core_integration test to make testing more efficient

Are these changes tested?

By CI. I also tested locally

You can see the tests run like this:

$ cargo test --test core_integration -- path_partition
   Compiling datafusion-physical-optimizer v40.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/physical-optimizer)
   Compiling datafusion v40.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/core)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 3.92s
     Running tests/core_integration.rs (target/debug/deps/core_integration-c1d878777c00ea56)

running 9 tests
test sql::path_partition::parquet_overlapping_columns ... ok
test sql::path_partition::parquet_statistics ... ok
test sql::path_partition::parquet_multiple_partitions ... ok
test sql::path_partition::parquet_multiple_nonstring_partitions ... ok
test sql::path_partition::csv_projection_on_partition ... ok
test sql::path_partition::csv_filter_with_file_nonstring_col ... ok
test sql::path_partition::csv_filter_with_file_col ... ok
test sql::path_partition::csv_grouping_by_partition ... ok
test sql::path_partition::parquet_distinct_partition_col ... ok

test result: ok. 9 passed; 0 failed; 0 ignored; 0 measured; 200 filtered out; finished in 0.07s

Are there any user-facing changes?

@alamb alamb changed the title Minor: move path_partition into core_integration Minor: consolidate path_partition test into core_integration Aug 5, 2024
@alamb alamb force-pushed the alamb/consolidate branch from e4bc409 to bef4044 Compare August 5, 2024 20:31
@github-actions github-actions bot added the core Core DataFusion crate label Aug 5, 2024
Copy link
Member

@lewiszlw lewiszlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lewiszlw lewiszlw merged commit 4a47dcb into apache:main Aug 6, 2024
@alamb alamb deleted the alamb/consolidate branch August 6, 2024 12:43
@alamb
Copy link
Contributor Author

alamb commented Aug 6, 2024

Thanks @lewiszlw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants