Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented Aug 8, 2024

This is part of isolating this module in order to be able to move it out
of core. This commit attempts to replace all crate:: imports that are
possible to avoid today (i.e. which would be replaced when listing table
provider was moved to separate crate), leaving those that cannot be
replaced. This makes it easy to notice the remaining coupling between
the listing table provider module and the core.

For #10782

@github-actions github-actions bot added the core Core DataFusion crate label Aug 8, 2024
@findepi findepi force-pushed the findepi/isolate-listing-01 branch from 680fc41 to 979e403 Compare August 8, 2024 13:27
This is part of isolating this module in order to be able to move it out
of core. This commit attempts to replace all `crate::` imports that are
possible to avoid today (i.e. which would be replaced when listing table
provider was moved to separate crate), leaving those that cannot be
replaced. This makes it easy to notice the remaining coupling between
the listing table provider module and the core.
@findepi findepi force-pushed the findepi/isolate-listing-01 branch from 979e403 to c2aab93 Compare August 8, 2024 14:24
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @findepi -- this change makes sense to me and it is a really clever / nice way to begin preparing to extract listing table

@alamb
Copy link
Contributor

alamb commented Aug 8, 2024

🚀

@alamb alamb merged commit 20fbd88 into apache:main Aug 8, 2024
@findepi findepi deleted the findepi/isolate-listing-01 branch August 9, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants