Skip to content

changed statistics to arc(statistics) #11885 #11893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

changed statistics to arc(statistics) #11885 #11893

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
707245b
changed statistics to arc(statistics)
albinsabu2023 Aug 8, 2024
946666f
corrected it to Option<Arc<Statistics>>
albinsabu2023 Aug 8, 2024
0ac97e4
Update mod.rs
albinsabu2023 Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datafusion/core/src/datasource/listing/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// or more contributor lpub statistics: Option<Arc<Statistics>>,icense agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
Expand Down Expand Up @@ -78,7 +78,7 @@ pub struct PartitionedFile {
///
/// DataFusion relies on these statistics for planning (in particular to sort file groups),
/// so if they are incorrect, incorrect answers may result.
Copy link
Contributor

@comphead comphead Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its probably worthy mentioning in the comments the reason why the Option<Arc> datatype was chosen

pub statistics: Option<Statistics>,

/// An optional field for user defined per object metadata
pub extensions: Option<Arc<dyn std::any::Any + Send + Sync>>,
}
Expand Down