Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 11, 2024

Which issue does this PR close?

N/A

Rationale for this change

We have a bunch of new crates, so let's update the labeler to reflect that

Here is the contents of datafusion:

andrewlamb@Andrews-MBP-2:~/Software/datafusion$ ls datafusion
CHANGELOG.md                       functions/                         physical-optimizer/
catalog/                           functions-aggregate/               physical-plan/
common/                            functions-aggregate-common/        proto/
common-runtime/                    functions-nested/                  proto-common/
core/                              optimizer/                         sql/
execution/                         physical-expr/                     sqllogictest/
expr/                              physical-expr-common/              substrait/
expr-common/                       physical-expr-functions-aggregate/ wasmtest/

What changes are included in this PR?

  1. Update labeler.yml to label PRs using updated crate names
  2. I also added the relevant labels to this repo (see https://github.com/apache/datafusion/issues/labels)

Are these changes tested?

No -- I figure we'll test them "in production" and update the rules as needed

Are there any user-facing changes?

@alamb alamb added the development-process Related to development process of DataFusion label Aug 11, 2024
@alamb alamb marked this pull request as ready for review August 12, 2024 10:34
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats great, thanks @alamb

@alamb
Copy link
Contributor Author

alamb commented Aug 12, 2024

Thanks for the review @comphead -- let's see how this works!

@alamb alamb merged commit ffdc61d into apache:main Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants