Skip to content

Conversation

@austin362667
Copy link
Contributor

Which issue does this PR close?

Closes #11963.

Rationale for this change

Since the renaming of functions-array to functions-nested, the referenced link to GitHub should be updated.

What changes are included in this PR?

Update https://github.com/apache/datafusion/tree/main/datafusion/functions-array to https://github.com/apache/datafusion/tree/main/datafusion/functions-nested in contributor-guide/howtos.

Are these changes tested?

Docs are successfully built locally.

Screen.Recording.2024-08-13.at.7.30.16.PM.mov

Are there any user-facing changes?

No, not from API level.

Signed-off-by: Austin Liu <austin362667@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 13, 2024

- Add the actual implementation of the function to a new module file within:
- [here](https://github.com/apache/datafusion/tree/main/datafusion/functions-array) for array functions
- [here](https://github.com/apache/datafusion/tree/main/datafusion/functions-nested) for array functions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [here](https://github.com/apache/datafusion/tree/main/datafusion/functions-nested) for array functions
- [here](https://github.com/apache/datafusion/tree/main/datafusion/functions-nested) for arrays, maps and structs functions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks for the review.

Signed-off-by: Austin Liu <austin362667@gmail.com>
@crepererum crepererum merged commit 8e23cba into apache:main Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link is outdated

2 participants