Throw not_impl_error for approx_percentile_cont parameters validation
#12133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
alamb
changed the title
no_impl_error for approx_percentile_cont parameters validation not_impl_error for approx_percentile_cont parameters validation
alamb
approved these changes
Aug 23, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @goldmedal -- this looks like an improvement to me
I had another suggestion on how to simplify the code, but it is certainly not required
| fn validate_input_percentile_expr(expr: &Arc<dyn PhysicalExpr>) -> Result<f64> { | ||
| let percentile = match get_scalar_value(expr)? { | ||
| ScalarValue::Float32(Some(value)) => { | ||
| let percentile = match get_scalar_value(expr).ok() { |
Contributor
There was a problem hiding this comment.
Another way to express this for your consideration that might make the error handling more obvious is
let scalar = match get_scalar_value(expr)
.map_err(not_impl_err!("Percentile value for 'APPROX_PERCENTILE_CONT' must be a litera, got: {expr}l")?
match scalar {
ScalarValue::Float32(Some(value)) => {
...
Contributor
Author
There was a problem hiding this comment.
It looks nice. Thanks for the suggestions!
Contributor
|
Thanks @goldmedal @alamb |
Contributor
Author
|
Thanks @alamb @jayzhan211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12012 .
Rationale for this change
What changes are included in this PR?
If the
percentileort-digestis invalid forapprox_percentile_cont, throwno_impl_errwith a readable message instead ofinternal_error.Are these changes tested?
yes
Are there any user-facing changes?
no