Skip to content

Use Result.unwrap_or_else where applicable #12166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Use Result.unwrap_or_else where applicable #12166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions datafusion/proto/tests/cases/roundtrip_logical_plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,8 @@ fn roundtrip_json_test(_proto: &protobuf::LogicalExprNode) {}
fn roundtrip_expr_test(initial_struct: Expr, ctx: SessionContext) {
let extension_codec = DefaultLogicalExtensionCodec {};
let proto: protobuf::LogicalExprNode =
match serialize_expr(&initial_struct, &extension_codec) {
Ok(p) => p,
Err(e) => panic!("Error serializing expression: {:?}", e),
};
serialize_expr(&initial_struct, &extension_codec)
.unwrap_or_else(|e| panic!("Error serializing expression: {:?}", e));
let round_trip: Expr =
from_proto::parse_expr(&proto, &ctx, &extension_codec).unwrap();

Expand Down