Remove unwrap_arc helper #12172
Merged
Remove unwrap_arc helper #12172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
It can now be replaced with single call `Arc::unwrap_or_clone`, with added bonus of slightly better name.
findepi
force-pushed
the
findepi/remove-unwrap-arc-helper-6fd7fe
branch
from
1e8d8fd to
1aeba15
Compare
Member
Author
|
This is related to @jonahgao 's comment #12166 (comment) @jonahgao do you want to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can now be replaced with single call
Arc::unwrap_or_clone, with added bonus of slightly better name.