Remove TableSource::supports_filter_pushdown function #12239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was deprecated since 20.0.0.
github-actions
bot
added
logical-expr
crepererum
approved these changes
Aug 29, 2024
lewiszlw
approved these changes
Aug 30, 2024
findepi
deleted the
findepi/remove-tablesource-supports-filter-pushdown-function-f94023
branch
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
Sep 10, 2024
The (singular) `TableSource::supports_filter_pushdown` was removed upstream. [1] I simply moved the method to the private `SqlTableSource::supports_filter_pushdown` because it is still used by the (plural) `TableSource::supports_filters_pushdown`. Additionally, the return type of `TableSource::get_logical_plan` was changed to Option<Cow<_>> upstream. [2] Refs [1]: apache/datafusion#12239 [2]: apache/datafusion#12113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was deprecated since 20.0.0.